On 9/12/06, Daniel Rall <dlr@collab.net> wrote:
> On Tue, 12 Sep 2006, Garrett Rooney wrote:
> ...
> > And for the curious, here's a patch. If there are no strong
> > objections soon I'll likely just commit it.
>
> +1, looks good. A couple very minor things:
>
> ...
> > Index: subversion/libsvn_ra_dav/fetch.c
> > ===================================================================
> > --- subversion/libsvn_ra_dav/fetch.c (revision 21461)
> > +++ subversion/libsvn_ra_dav/fetch.c (working copy)
> ...
> > @@ -420,9 +415,7 @@
> > ne_request *req;
> > ne_decompress *decompress;
> > svn_error_t *err;
> > -#ifndef SVN_NEON_0_25
> > int decompress_rv;
> > -#endif /* ! SVN_NEON_0_25 */
>
> The decl for decompress_rv should be removed, too.
>
> ...
> > Index: subversion/libsvn_ra_dav/util.c
> > ===================================================================
> > --- subversion/libsvn_ra_dav/util.c (revision 21447)
> > +++ subversion/libsvn_ra_dav/util.c (working copy)
> ...
> > @@ -664,9 +653,7 @@
> > ne_xml_parser *success_parser = NULL;
> > ne_xml_parser *error_parser = NULL;
> > int rv;
> > -#ifndef SVN_NEON_0_25
> > int decompress_rv;
> > -#endif /* ! SVN_NEON_0_25 */
>
> Ditto.
Oops, accidentally read those as ifdef, not ifndef. Thanks for the review Dan!
Since nobody seems to be really objecting here, I'll commit the change
as soon as this build finishes.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 13 18:49:33 2006