On Tue, 12 Sep 2006, Alex Waugh wrote:
> "Garrett Rooney" <firstname.lastname@example.org> wrote:
> > On 9/7/06, Alex Waugh <email@example.com> wrote:
> > > Hi
> > >
> > > On platforms where APR_HAS_DSO is not defined, Subversion no longer
> > > compiles. This patch fixes it.
> > Interesting. What platform is this, just out of curiosity?
> RISC OS
> > I'm not sure if the patch is entirely correct... Should we really
> > just not have svn_dso_load, or should we just make it return an
> > APR_ENOTIMPL error?
> The problem is that the apr_dso_handle_t type is not defined unless
> APR_HAS_DSO is set, so the compiler falls over on the function
> prototype as well as the actual code.
Our other uses of svn_dso_load() and apr_dso_handle_t in fs-loader.c
and ra_loader.c already gate it in "#if APR_HAS_DSO" checks. I've
committed Alex's patch in r21473 (with some very minor stylistic
tweaks), and nominated it for backport to the 1.4.x line.
An alternate approach which returns something like APR_ENOTIMPL would
need to further insulate svn_dso.h from APR's #if/#ifdef's.
Received on Wed Sep 13 00:33:29 2006
- application/pgp-signature attachment: stored