On Sat, 19 Aug 2006, Daniel Westermann-Clark wrote:
> Apologies for the slow response. I've attempted to take your
> suggestions into account, but the changes are a bit more significant
> this time around. :)
Very nice job, Daniel! From your response to the review, to the log
message, to change itself, fantastic work all around.
> On 2006-08-01 10:07:46 -0700, Daniel Rall wrote:
> > commit.c has the interrogate_for_location() routine for doing this
> > work. Would it be possible to refactor both variations of
> > "Location" header retreival logic into there, and maintain an API
> > which is compliant with Neon 0.25?
> I've done a bit of refactoring to svn_ra_dav__request_interrogator
> in order to make it backwards compatible.
> The function interrogate_for_location from commit.c has been moved to
> The two request interrogator arguments to svn_ra_dav__request_dispatch
> are now part of the function's prototype regardless of Neon version.
> This required making the function interrogate_for_content_type in
> fetch.c backwards compatible also.
> > While we don't use ne_free() in other places we access the
> > "Location" header, since we get the data from Neon I think we
> > should. (It's simply #define'd to free() on my Linux box.)
> I was unsure about this; I've changed it to ne_free in the latest
> version of the patch.
I've made some very minor tweaks, and have committed your patch to
Subversion's trunk in r21442.
Received on Mon Sep 11 23:09:49 2006
- application/pgp-signature attachment: stored