On Thu, 07 Sep 2006, Mathias Weinert wrote:
> C. Michael Pilato wrote:
> > C. Michael Pilato wrote:
> > > Mathias Weinert wrote:
> > >> Hi,
> > >>
> > >> I still like to implement the recognition of replaced paths in
> > >> mailer.py. In order to achieve this I need a change of
> > >> subversion/bindings/swig/python/svn/repos.py which I already posted
> > >> to the dev list and for which I already got replies - but no commit.
> > >>
> > >> So if there is anybody out there willing to commit my patch (with or
> > >> without the change proposed by cmpilato) please commit it.
> > >>
> > >> Original patch/post:
> > >> http://svn.haxx.se/dev/archive-2006-08/0612.shtml
> > >>
> > >> Last patch provided by me:
> > >> http://svn.haxx.se/dev/archive-2006-08/0956.shtml
> > >>
> > >> cmpilato's reply:
> > >> http://svn.haxx.se/dev/archive-2006-08/0969.shtml
> > >>
> > >> Thank you very much!
> > >
> > > Attached is an updated patch that has my proposed change. I'm not able
> > > to clearly think through the compatibility issues here, but I *think*
> > > that making the new parameter optional buys us all that we need.
> >
> > Ooh. And attached to *this* mail is alternative (much older) patch that
> > I just found in my ~/misc/PATCHES directory which takes this problem a
> > different direction altogether. Rather than continuing to grow these
> > custom action fields (added, replaced, etc.) it just adds an 'action'
> > field and a list of testable actions.
> >
> [...]
>
> I don't mind which version of the patch will be applied. I will just be
> happy if any will be applied ;) so that I can go on with some other
> changes to mailer.py.
>
> Who will decide which one to apply? Is it yourself?
> And who will then commit it?
Mathias, you've commit access. With Mike now out of town, feel free
to use your best judgement as to which patch to apply. For a change
like this, typically the bias would be towards ease of maintenance
(which probably leans towards Mike's last posted patch?).
- application/pgp-signature attachment: stored
Received on Mon Sep 11 20:15:26 2006