[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't create lock directory in repos if not needed

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-09-11 15:18:04 CEST

On Mon, Sep 11, 2006 at 02:12:27PM +0200, Mathias Weinert wrote:
> while updating my repository (FSFS) to 1.4.0 I noticed that the content
> of the two files in the lock directory changed, now saying:
> This file is not used by Subversion 1.3.x or later.
> However, its existence is required for compatibility with
> Subversion 1.2.x or earlier.
> As a repository created with version 1.4.0 (or later) without using the
> option --pre-1.4-compatible isn't accessible by any older Subversion
> version (on the server side) I think that in this case these files don't
> have to be created at all.

I took a look at this myself, and I'd moved the logic to create_locks()
(see attached patch) so that hotcopy wouldn't create the locks dir
when it creates a new repository, but I also noticed that hotcopy will
unconditionally create (and lock) one of the lock files in the _source_
repository as well, just in case it's not there.

Now I don't think that lock_db_logs_file() needs to be creating the lock
file any more (unless we want to support hotcopying pre-1.0 repositories),
but that's a separate issue.

Unfortunately, we can't just stop creating the locks/ dir, because even
if we fix 1.4.1 so that it doesn't need a log lock-file, 1.4.0 will
still try to create that lockfile and so hotcopy will fail, I think.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 11 15:21:30 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.