Re: svn commit: r21407 - trunk/subversion/tests/libsvn_repos

glasser@tigris.org wrote:
> Author: glasser
> Date: Sun Sep 10 14:14:29 2006
> New Revision: 21407
>
> Log:
> New lower-level test for Issue #2608. Passes with bdb, fails with
> fsfs. (There's no way to do a conditional XFAIL for C tests
> unforunately.)
>
>
> struct locations_info
> @@ -1759,6 +1811,7 @@
> SVN_TEST_PASS(dir_deltas),
> SVN_TEST_PASS(node_tree_delete_under_copy),
> SVN_TEST_PASS(revisions_changed),
> + SVN_TEST_PASS(created_rev_root),
> SVN_TEST_PASS(node_locations),
> SVN_TEST_PASS(node_locations2),
> SVN_TEST_PASS(rmlocks),
>
Dave,

please don't commit tests of which you know upfront that they are going
to fail.

In this case, it's better to mark the test as XFail. If the test passes
on bdb, that's ok, it'll be shown as XPASS in the test output.

Fixed in r21408.

thanks,

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 10 23:53:30 2006