[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21373 - trunk/subversion/bindings/swig/python/libsvn_swig_py

From: David James <djames_at_collab.net>
Date: 2006-09-07 23:08:42 CEST

On 9/7/06, Blair Zajac <blair@orcaware.com> wrote:
> djames@tigris.org wrote:
> > Author: djames
> > Date: Thu Sep 7 01:38:21 2006
> > New Revision: 21373
> >
> > Log:
> > Don't dangerously borrow references to underlying Python streams
> > in swig_py_make_stream. Instead, keep track of the reference count
> > for the underlying Python stream. By keeping track of the reference
> > count, we ensure that the Python garbage collector won't delete the
> > stream from under us while we still need it.
> >
> > Branch: trunk
> > Release: 1.5.x
> Hi David,
> I've started to notice the new Branch and Release notes in your commit messages.
> Maybe this was discussed on the dev list and I missed it, but what's the point
> of listing them? We haven't cut the 1.5.x branch yet so I know that it'll end
> up in 1.5.x and I know from the email message and any log output that this is
> was done on trunk.
> So it seems redundant information, and requires mental energy to look at it and
> potentially check it.

I think that this information might sometimes be handy, for instance,
if you are reviewing the log message a few years from now and want to
check whether the bugfix is in a specific release. Then again, it's
not very hard to run svn log on the branch to find out what revision
it was cut from, and it does make the commit message a bit longer. So,
I won't bother putting in the 'Branch' and 'Release' field for commits
to trunk.

Commits to branches, on the other hand, are a bit trickier to pin
down. If you look at an old commit to a feature branch, it might be a
bit tricky to find out when that merge was committed to trunk, so
Release tags might be useful.

'Branch' tags can also be useful, but for different reasons. Folks who
work on feature branches or release branches tend to list the branch
name in the commit message just so people don't accidentally think
that the change was committed to trunk.

Usually, folks start their commit message with a sentence like: "On
the merge-tracking branch", so there's no need for an explicit field
in the message. Either way, it's useful information.



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 7 23:14:03 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.