Re: svn commit: r21361 - in branches/incomplete-directories/subversion: libsvn_ra_dav libsvn_ra_serf libsvn_ra_svn mod_dav_svn/reports svnserve

Peter Samuelson <peter@p12n.org> writes:
>> + if (depth != svn_depth_infinity)
>> + depthstring = apr_psprintf(pool, "depth=\"%d\"", depth);
>> +
>> if (lock_token)
>> tokenstring = apr_psprintf(pool, "lock-token=\"%s\"", lock_token);
>>
>> svn_xml_escape_cdata_cstring(&qpath, path, pool);
>> - /* ### TODO: send depth here */
>> if (start_empty)
>> entry = apr_psprintf(pool,
>> - "<S:entry rev=\"%ld\" %s"
>> + "<S:entry rev=\"%ld\" %s %s"
>> " start-empty=\"true\">%s</S:entry>" DEBUG_CR,
>
> Is it worth the trouble to put a leading space into 'depthstring' and
> 'tokenstring' above, instead of in this format string, so that the wire
> data looks a bit neater (only one space)? The code is no more complex
> or anything, so I guess it's just a question of whether it would be
> considered equally readable.

Could go either way (I find this way more readable, personally...).

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 7 23:10:38 2006