[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add Windows path handling to svn_path functions (issue #1711)

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2006-09-06 21:34:01 CEST

Garrett Rooney wrote:
> On 9/1/06, Lieven Govaerts <svnlgo@mobsol.be> wrote:
>> +svn_boolean_t
>> +svn_path_is_absolute(const char *path, apr_size_t len, apr_pool_t *pool)
>> +{
>> + const char *root_path = NULL;
>> + apr_pool_t *strpool = (pool) ? pool : svn_pool_create(NULL);
> Since this is a new function, and we don't seem to require the ability
> to pass a NULL pool, I'd remove that functionality until it proves
> necessary.

Heh, yeah, somebody must have copy-pasted that code from another
function :). I removed it.

> Other than that this seems fine to me, +1 to commit.

Thanks for the review, committed in r21369.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 6 21:36:22 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.