[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] issue #850: remove references to internal APR headers

From: Matthias Miller <Blog_at_OutOfHanwell.com>
Date: 2006-09-05 21:48:45 CEST

I have included a patch to remove references to internal APR headers. It
appears that these headers are unnecessary, and it prevents a clean apr
install in a MinGW/msys environment.

-Matthias Miller

[[[
* subversion/libsvn_subr/nls.c: remove references to internal APR headers

* subversion/libsvn_subr/config_win.c: remove references to internal APR
headers
]]]

Index: subversion/libsvn_subr/nls.c
===================================================================
--- subversion/libsvn_subr/nls.c (revision 21357)
+++ subversion/libsvn_subr/nls.c (working copy)
@@ -34,15 +34,7 @@
 
 #include "svn_private_config.h"
 
-#ifdef WIN32
-/* FIXME: We're using an internal APR header here, which means we
- have to build Subversion with APR sources. This being Win32-only,
- that should be fine for now, but a better solution must be found in
- combination with issue #850. */
-#include <arch/win32/apr_arch_utf8.h>
-#endif
 
-
 svn_error_t *
 svn_nls_init(void)
 {
Index: subversion/libsvn_subr/config_win.c
===================================================================
--- subversion/libsvn_subr/config_win.c (revision 21357)
+++ subversion/libsvn_subr/config_win.c (working copy)
@@ -27,11 +27,6 @@
 #include <shlobj.h>
 
 #include <apr_file_info.h>
-/* FIXME: We're using an internal APR header here, which means we
- have to build Subversion with APR sources. This being Win32-only,
- that should be fine for now, but a better solution must be found in
- combination with issue #850. */
-#include <arch/win32/apr_arch_utf8.h>
 
 #include "svn_error.h"
 #include "svn_path.h"

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 5 21:50:41 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.