[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Log message deficiency for r20946.

From: Karl Fogel <kfogel_at_google.com>
Date: 2006-09-05 20:35:39 CEST

r20946 changed the names of a number of symbols, but did not list all
the changed names. I finally figured this out after spending some
time looking into a user's problem with dav_svn_get_repo_name(). The
first thing I discovered is there is no such function in the current
sources, and the last mention of it in the logs was from April, 2002.

Figuring out where it went it took some time :-).

It's true that http://subversion.tigris.org/hacking.html#log-messages
talks about the "tension between making entries easy to find by
searching for identifiers, and wasting time or producing unreadable
entries by being exhaustive". If one is making the same trivial
change to a number of function bodies, for example, there is no need
to list all the affected functions. But if one is *changing the
names* of symbols, then it's important to list them all, both new and
old. This is the only way the renaming of a particular symbol can be
tracked down later.

I've fixed r20946's log message. For reference, the original message

> mod_dav_svn: A huge bunch more removal of unnecessary dav_svn_
> namespace qualifiers and application of double-underscore policy,
> and related minor tweaks.
> [in subversion/mod_dav_svn/]
> * mod_dav_svn.c, deadprops.c, liveprops.c, dav_svn.h, version.c, lock.c,
> repos.c, authz.c: Loads of minor changes.

If anyone knows of similar revisions, please fix 'em up. I'll edit
hacking.html to point out this situation.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 5 20:36:46 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.