[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking] remove unused variable

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-09-01 08:20:13 CEST

Karl Fogel wrote:
> Kamesh Jayachandran <kamesh@collab.net> writes:
>
>> Can someone look in to this?
>>
>
> This has apparently already been fixed on trunk (though I can't find
> the revision), or else the problem only exists on a branch. Did you
> spot this on the merge-tracking branch, maybe?
>
> -Karl
>
I believe this 'unused' variables have been introduced at r19643 on
merge-tracking branch by dberlin.
So any merge from trunk will be of no use as this is the
'merge-tracking' branch change.

With regards
Kamesh Jayachandran

>
>> Kamesh Jayachandran wrote:
>>
>>> Hi All,
>>> Find the attached patch.
>>>
>>> With regards
>>> Kamesh Jayachandran
>>>
>>> [[[
>>> Patch by: Kamesh Jayachandran <kamesh@collab.net>
>>>
>>> * subversion/libsvn_fs_fs/tree.c
>>> (fs_change_node_prop):
>>> ffd is unused, remove it.
>>> ]]]
>>>
>>> ------------------------------------------------------------------------
>>>
>>> Index: subversion/libsvn_fs_fs/tree.c
>>> ===================================================================
>>> --- subversion/libsvn_fs_fs/tree.c (revision 21214)
>>> +++ subversion/libsvn_fs_fs/tree.c (working copy)
>>> @@ -1419,14 +1419,11 @@
>>> parent_path_t *parent_path;
>>> apr_hash_t *proplist;
>>> const char *txn_id;
>>> - fs_fs_data_t *ffd;
>>> if (! root->is_txn_root)
>>> return not_txn(root);
>>> txn_id = root->txn;
>>> - ffd = root->fs->fsap_data;
>>> -
>>> SVN_ERR(open_path(&parent_path, root, path, 0, txn_id, pool));
>>> /* Check (non-recursively) to see if path is locked; if so,
>>> check
>>>
>>> ------------------------------------------------------------------------
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>>> For additional commands, e-mail: dev-help@subversion.tigris.org
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>> For additional commands, e-mail: dev-help@subversion.tigris.org
>>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 1 08:20:23 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.