Re: [PATCH] recognize replaced paths in mailer.py (needs change in svn/repos.py)
Mathias Weinert wrote:
>> Andr� Malo wrote:
>>> * Mathias Weinert wrote:
>>>> Andr� Malo wrote:
>>>>> wrt the changes in repos.py: This should be documented in the change
>>>>> log I think, as it's an incompatible change.
>>>> Sorry, but I don't understand what you want to say here. Could you
>>>> please explain this to me (what is incompatible with what)? Thanks.
>>> svn.repos is a common library. So if something's changed there in a
>>> backwards incompatible way, it should be noted at some place where
>>> developers can find it (before updating).
>> So what about the following patch. It doesn't change the parameter list
>> of __init__ (and is smaller anyway)?
> Anyone willing to commit my patch (or to modify it)?
> Without someone patching the python bindings I can't commit the change
> to mailer.py (which I really would like to).
> Thank you very much!
> --- repos.py.orig 2006-08-10 09:15:33.801134900 +0200
> +++ repos.py 2006-08-22 16:46:00.184779900 +0200
> @@ -50,6 +50,12 @@
> ### if the rev is always repos.rev - 1, or whether it represents the
> ### created or time-of-checkout rev. so... we use a flag (for now)
> self.added = added
> + ### this additional flag is needed to store information if a path was
> + ### a newly added one or if it was a replace action
> + ### it cannot be set be __init__ in order to leave the parameter list
> + ### unchanged
> + self.replaced = False
Is there an issue with adding it as the final parameter with a default
def __init__(self, ..., replaced=False):
C. Michael Pilato <firstname.lastname@example.org>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on Wed Aug 30 19:46:00 2006
This is an archived mail posted to the Subversion Dev