[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [merge-tracking] Code clarity fix

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2006-08-30 16:21:05 CEST

>
>
> Index: subversion/libsvn_subr/mergeinfo.c
> ===================================================================
> --- subversion/libsvn_subr/mergeinfo.c (revision 21302)
> +++ subversion/libsvn_subr/mergeinfo.c (working copy)
> @@ -76,15 +76,13 @@
> else if (in1->start >= in2->start
> && in1->end <= in2->end)
> {
> - (*output)->start = in2->start;
> - (*output)->end = in2->end;
> + *(*output) = *in2;
> return TRUE;
> }
> else if (in2->start >= in1->start
> && in2->end <= in1->end)
> {
> - (*output)->start = in1->start;
> - (*output)->end = in1->end;
> + *(*output) = *in1;
> return TRUE;
> }

I actually believe this makes the code much less clear (it's also not
faster, since the compiler will transform it back into a block copy if
it makes sense).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 30 16:51:57 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.