[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Clearing up some API ambiguity (@-syntax)

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-08-29 17:08:27 CEST

On 8/29/06, C. Michael Pilato <cmpilato@collab.net> wrote:

> Well, there's the rub. Right now, we don't decode. And the result is
> that 'svn cat URL@{date}' doesn't work at all today.
>
> $ svn cat http://svn.collab.net/repos/svn/trunk/CHANGES@{2006-03-05}
> subversion/libsvn_subr/opt.c:739: (apr_err=205000)
> svn: Syntax error parsing revision '%7B2006-03-05%7D'
>
> (It was that problem I was trying to solve.)
>
> This doesn't work today because Subversion itself first URI-encodes the
> input (it being all IRI-permissive and such), and because our function
> doesn't decode it again, handing off the encoded stuff to a function
> that can't deal with such things.
>
> So the answer to my question will reveal what work needs to be done:
>
> * If we expect the whole thing to be URI-encoded, no sweat -- I
> just make this function decode the part after the @-sign and
> I'm golden. (Really golden -- I already have a patch for this.)
>
> * However, if we expect the endstuffs to *not* be encoded (like,
> they aren't *really* part of the URL), then there's a bigger
> problem to solve in that opt_to_target_array() needs to stop
> encoding that stuff (and that's a trickier change to pull off).

I vote for the easy one ;-)

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 29 17:47:31 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.