[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Revision dates in URLs

From: Nilton Volpato <nilton.volpato_at_gmail.com>
Date: 2006-08-26 22:33:11 CEST

On 8/26/06, David Glasser <glasser@mit.edu> wrote:
> On 8/25/06, Nilton Volpato <nilton.volpato@gmail.com> wrote:
> > But if I use URL@{DATE} it does not work. For instance:
> >
> > # svn co http://path/to/rep/@{2006-08-25}
> > svn: Syntax error parsing revision '%7B2006-08-25%7D'
> This is probably a bug, since the docs for svn_opt_parse_path imply
> that (internally) date pegrevs are kosher. But the strings passed to
> that generally come out of svn_opt_args_to_target_array2, which does
> URI "autoescaping" on URLs with svn_path_uri_autoescape, and that
> escapes { and }.
> I'm not sure what the right answer is -- perhaps
> svn_opt_args_to_target_array2 should look for and not autoescape a
> pegrev part. That seems like it's reverting towards the behavior of
> svn_opt_args_to_target_array though, and I don't know the motiviation
> behind that change. (Not that it actually worked back in 1.1 or 1.0
> either.)
> --dave
> --
> David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/

This is now an issue, with number 2602.

Attached is a proposed patch to fix this issue.

It's working, although it needs some revision as I'm not certain I
used svn_stringbuf* correctly, and I don't know if I should somehow
free the old "target" variable at line 849.

-- Nilton

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sat Aug 26 22:33:41 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.