[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] check-case-insensitive.py: Don't use 'string' library

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-08-25 16:39:11 CEST

Bhuvaneswaran Arumugam wrote:
> Hello,
> Please find attached the patch for your review.
> [[
> Do not use "string" library and fix a bug in Usage statement.
> Patch by: bhuvan
> * contrib/hook-scripts/check-case-insensitive.py
> (global): Do not import "string" library
> (Editor.add_directory):
> (Editor.add_file):
> (CheckCase.showfile):
> Use the variable itself to convert it to lower case.
> (__main__): Use the script name in the Usage statement.
> ]]

Log message is a little wonky. Suggest:

   * contrib/hook-scripts/check-case-insensitive.py
     (global): Do not import "string" library
     (Editor.add_directory, Editor.add_file, CheckCase.showfile): Fix
       uses of deprecated string methods.
     (__main__): Include the script's name in the usage statement.

That said, I see three distinct commits you could make here:

   1. fix the usage message bug
   2. de-'string'-ify the script
   3. fix those unpythonic conditionals that Kamesh mentioned

You've got my +1 to commit all three changes separately to
check-case-insensitive.py. Be sure to add "Approved by: cmpilato" to
the log messages.

C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Fri Aug 25 16:40:36 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.