Re: [PATCH] check-case-insensitive.py: Don't use 'string' library

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2006-08-25 10:56:20 CEST

On Fri, 2006-08-25 at 14:18 +0530, Kamesh Jayachandran wrote:
> > @@ -288,17 +287,17 @@
> > else:
> > changedpath = changedroot + '/' + path
> > for added in changed.added:
> > - if (string.lower(added) == string.lower(changedpath)):
> > + if (added.lower() == changedpath.lower()):
> >
> The brackets around the conditional expression seems less pythonic. My 2
> cents :).

Yes, you are right. But i wanted it to make it separate from the
functional spec patch. Anyhow please find attached the revised patch for
review!

-- 
Regards,
Bhuvaneswaran

text/x-patch attachment: check-case-insensitive.py.diff__charset_utf-8

application/pgp-signature attachment: This is a digitally signed message part

Received on Fri Aug 25 10:57:03 2006

This message: [ Message body ]
Next message: Kamesh Jayachandran: "Re: [PATCH][merge-tracking]diskfile merge info hash to in memory mergeinfo."
Previous message: Kamesh Jayachandran: "Re: [PATCH] check-case-insensitive.py: Don't use 'string' library"
In reply to: Kamesh Jayachandran: "Re: [PATCH] check-case-insensitive.py: Don't use 'string' library"

Contemporary messages sorted: [ By Date ] [ By Thread ] [ By Subject ] [ By Author ] [ By messages with attachments ]