Re: [PATCH] Need to bump repos format number for 1.4.0

On Mon, Aug 21, 2006 at 05:17:16PM +0100, Malcolm Rowe wrote:
> On Tue, Aug 15, 2006 at 03:35:28PM +0100, Max Bowsher wrote:
> How about something like the attached? (Warning: untested).
>
> [[[
> Conditionally bump the format number of newly-created repositories to 4,
> depending on whether the created filesystem format number is greater than 1.
>
> ...
>

Actually, this seems to work pretty well. For most operations, this
produces:

    svnadmin: Expected format '3' of repository; found format '4'
instead of:
    svnadmin: Expected FS format '1'; found format '2'

Prior to this change, older clients that didn't check the filesystem
format number would sometimes work:

    $ svnadmin dump repo/ -r0:2 > /dev/null
    * Dumped revision 0.
    * Dumped revision 1.
    * Dumped revision 2.

And sometimes wouldn't:

    $ svnadmin dump repo/ -r0:3 > /dev/null
    * Dumped revision 0.
    * Dumped revision 1.
    * Dumped revision 2.
    svnadmin: Invalid diff stream: insn 1 cannot be decoded

And note that while that's demonstrating a failure to read, there's no
reason that a similar failure might not occur during a write (to a file://
repository, for example).

I know that Max would like to use a different mechanism from
poking-the-format-file to determine whether we can use repository format
3 or 4, but I though it might be useful to note that the basic idea
appears sound.

[I didn't actually use a 1.1-era svnadmin, but hacked fs/format back to
'1' to get the same effect. I think this is valid.]

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 22 18:04:51 2006