[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20781 - trunk

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-08-22 14:42:03 CEST

Justin Erenkrantz wrote:
> On 8/8/06, Daniel Rall <dlr@collab.net> wrote:
>> > Ditto.
>> >
>> > I'm also concerned that there is a spurious -print in autogen.sh right
>> > now that causes a bunch of junk to be printed - there's no need to
>> > emit any info even if we were to delete the pyc's from autogen.sh. --
>> Max, any updates on this one?
> Max: *ping*
> If we don't hear back in a few days, I will, at the very least, remove
> the -print argument to find. But, I may also just as likely revert
> this entire commit... -- justin

Sorry for the lack of response - finding a job, and then finding
somewhere to live whilst working in that job, have taken a rather large
amount of my time recently.

1) the -print argument

I put that in deliberately, because autogen.sh is fairly a fairly chatty
script, and mentions most of the files it operates on, in its stdout

2) presence in autogen.sh not dish.sh

autogen.sh already contains tarball-rolling-specific operations - see
the $RELEASE_MODE conditional.

I could happily put the find command inside another $RELEASE_MODE
conditional if that's preferred.

Also, note the "rm autogen-standalone.mk" command immediately following
the find command. That is a miscellaneous cleanup command too - if the
find command is deemed inappropriate here, I think the rm must also be.


Received on Tue Aug 22 14:43:06 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.