[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for issue #2556: support working copies on the root of a (virtual) drive

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-08-21 22:22:10 CEST

On 8/21/06, Erik Huelsmann <ehuels@gmail.com> wrote:

> Ok. I didn't investigate more of it myself, so I rely on you to make
> sure that we call svn_path_is_root from other functions which don't
> have a pool (excluding is_canonical, since Philip said we can safely
> remove that function from consideration).
> However, calling svn_pool_create(NULL) isn't thread safe AFAIK,
> because it allocates from the main pool (is this right, Branko,
> anybody?). Or is that the only bit for which the main pool *is*
> protected?

Incorrect, creating a new global pool (via svn_pool_create(NULL))
should be thread safe (allocating things directly from the global pool
yourself is not necessarily thread safe though, although you have to
jump through hoops to get a handle on it anyway), it's just not
something you really want to do very often because it's kinda slow.
Creating a new pool involves allocating about 8k of data, which is
kind of silly if you're just going to use it for one tiny thing then
destroy it.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 21 22:36:52 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.