[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for issue #2556: support working copies on the root of a (virtual) drive

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2006-08-20 23:59:40 CEST

Lieven Govaerts <lgo@mobsol.be> writes:

> However, there's another reason why I create a subpool. The function
> is_canonical (private function in path.c) is calling svn_path_is_root,
> but that function doesn't have a pool available and is called by other
> functions which don't have pool parameters.

Perhaps it's time to get rid of is_canonical? I added it when I was
attempting to catch the places where the svn client was not passing
canonical paths, it was cheap and efficient so I just scattered it
through the path code. If it's not removed then it's use could be
restricted to those places that do have pools.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 21 00:00:06 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.