Re: failure in 1.4.0-rc4 ruby testsuite on AMD64

> >Kouhei Sutou wrote:
> >>@@ -169,7 +169,8 @@
> >> char *tbuf;
> >> apr_size_t tlen;
> >>
> >>- tbuf = ALLOCA_N(char, (window->tview_len + 1));
> >>+ tlen = window->tview_len + 1;
> >>+ tbuf = ALLOCA_N(char, tlen);
> >> svn_txdelta_apply_instructions(window, sbuf, tbuf, &tlen);
> >>
> >> return rb_str_new(tbuf, tlen);

[Nik Clayton]
> Should a comment be added, explaining that this is here to fix a bug?
> In 6 months time someone's liable to look at that code, wonder why
> there's a temporary variable, and probably put things back in the
> name of making the code cleaner.

It's not adding a temporary variable, it's initialising a variable
which will be used on the next line. I don't think a comment is
needed.