Re: failure in 1.4.0-rc4 ruby testsuite on AMD64

Kouhei Sutou wrote:
> Hi,
>
> I'm sorry for my late response.
>
> 2006/8/4, Peter Samuelson <peter@p12n.org>:
>
>> My colleague Troy Heber reports that 1.4.0-rc4 'make check-swig-rb'
>> fails on his AMD64 machine running Debian unstable. Can anyone
>> reproduce the failure below, on an amd64? If not, we will treat it as
>> probably a Debian-specific ruby bug, which would hardly be the first
>> we've seen.
>
>> 1) Failure:
>> test_txdelta_apply_instructions(SvnDeltaTest)
>
> Does attached patch solve this problem?

Yes, it does! Congratulations, Kouhei, on tracking this one down. :-)
Please go ahead and commit it, and nominate it in STATUS for 1.4.x too.

Thanks,
Max.

> Index: subversion/bindings/swig/svn_delta.i
> ===================================================================
> --- subversion/bindings/swig/svn_delta.i (revision 21073)
> +++ subversion/bindings/swig/svn_delta.i (working copy)
> @@ -169,7 +169,8 @@
> char *tbuf;
> apr_size_t tlen;
>
> - tbuf = ALLOCA_N(char, (window->tview_len + 1));
> + tlen = window->tview_len + 1;
> + tbuf = ALLOCA_N(char, tlen);
> svn_txdelta_apply_instructions(window, sbuf, tbuf, &tlen);
>
> return rb_str_new(tbuf, tlen);