Re: atomic revprop commits at the RA level

On 8/9/06, David Glasser <glasser@mit.edu> wrote:

> The other alternative would be to deprecate svn_ra_get_commit_editor2
> for an svn_ra_get_commit_editor3

This is a feature we've wanted for a very long time. I think the only
sane design is to extend our editor vtable to include a function for
attaching properties to the transaction.

Once upon a time, we envisioned the editor vtable as being perfectly
symmetric... being used to commit from client to server, and to update
from server to client. But it's already got a few asymmetries (like
editor->set_target_revision, for example, which only goes from
server->client.) A txn_propset function would be a new asymmetry, so
it's ugly in a small sense, but overall I think it fits our design of
'how commits work'. If you want to do a commit, you get *one* vtable.
 It's a clean and simple.

So I'd very much like to see a rev'd editor. As long as we're going
to go through such pain... weren't there other things we wanted to add
to the editor?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 10 15:31:31 2006