Re: [PATCH] Moving/copying added files and dirs

On 8/8/06, Ivan Zhakov <chemodax@gmail.com> wrote:

> Second problem in setup_copy():
> if (!src_is_url)
> {
> /* Are we copying/moving a path that is scheduled for addition? */
> SVN_ERR(svn_wc_adm_probe_open3(&adm_access, NULL, src_path, FALSE, 0,
> ctx->cancel_func, ctx->cancel_baton,
> pool));
> SVN_ERR(svn_wc_entry(&entry, src_path, adm_access, FALSE, pool));
> SVN_ERR(svn_wc_adm_close(adm_access));
> src_is_add = (entry && entry->revision == 0) ? TRUE : FALSE;
> }
> Might be I forget something, but AFAIK zero revision number is valid.
> So you should check against SVN_INVALID_REVNUM or check url field. I
> don't remember exactly.

Well, 0 is a valid revision, but it'll only ever exist on the root of
the repos, so it's not something you can actually copy...

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 8 21:04:24 2006