[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Refactor the bdb atomic initialization code into a generic implementation

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-08-08 17:35:33 CEST

On 8/8/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:

> [[[
> Extract the atomic initialization code from libsvn_fs_base/bdb/env.c
> and convert it to a generic implementation that can be used to
> initialize other libraries (*cough* Cyrus SASL *cough*). Make bdb use
> the new implementation.
> * subversion/include/private/svn_atomic.h: New file.
> * subversion/libsvn_subr/atomic.c: New file.
> * subversion/libsvn_fs_base/bdb/env.c
> Include svn_atomic.h instead of apr_atomic.h.
> (svn__atomic_t,
> svn__atomic_read,
> svn__atomic_set,
> svn__atomic_cas): These are now in subversion/include/svn_atomic.h
> and have a single
> underscore. All calls were changed to reflect this.
> BDB_CACHE_INITIALIZED): Deleted. Similar definitions are now in atomic.c.
> (bdb_cache_state): This is no longer declared inside an #ifdef
> and is no longer explicitly initialized.
> (svn_fs_bdb__init_cb): New function. Contains bdb-specific initialization.
> (svn_fs_bdb__init): Call svn_atomic_init_once().
> ]]]

This looks great to me, committed with some minor tweaks in r21016.



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 8 17:36:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.