[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Add private include area for Subversion-private APIs used between modules

From: Vlad Georgescu <vgeorgescu_at_gmail.com>
Date: 2006-08-06 11:39:55 CEST

On 8/5/06, Daniel Rall <dlr@collab.net> wrote:
> > Garrett Rooney wrote:
> > > Perhaps a new subversion/include/private directory for such things is
> > > in order, for headers that are used in various libraries but should
> > > not be installed. That would be somewhat nicer than the current
> > > practice of doing something like:
> > >
> > > #include "../libsvn_subr/atomics.h"
>
> +1! Inter-module APIs aren't necessarily always public. Introduction
> of a private include area (APR/APR-Util do something similar) would
> allow us with a clear way to share non-public APIs.

I created subversion/include/private and added
subversion/include/private/*.h to private-includes in build.conf, but
ran into a slight problem. Running autogen.sh generates a warning
about missing header files when it encounters includes with a path
component (e.g. #include "private/svn_atomic.h"), if the path isn't
relative to the current directory:

Creating build-outputs.mk...
WARNING: "private/svn_atomic.h" header not found, file
subversion/libsvn_subr/atomic.c
WARNING: "private/svn_atomic.h" header not found, file
subversion/libsvn_fs_base/bdb/env.c

Any ideas on how to fix this? The relevant code is in
_scan_for_includes in gen_base.py.

-- 
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 6 11:40:23 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.