Re: svnversion on a file

"David Glasser" <glasser@mit.edu> writes:

> - SVN_INT_ERR(svn_wc_check_wc(wc_path, &wc_format, pool));
> + /* As we can only call svn_wc_check_wc on directories, if we were
> + passed a file on the command-line, use its parent directory there
> + instead. (We still find the original file's revision later.) */
> + SVN_INT_ERR(svn_io_check_path(wc_path, &kind, pool));
> + if (kind == svn_node_file)
> + {
> + wc_check_path = svn_path_dirname(wc_path, pool);
> + }
> + else
> + {
> + wc_check_path = wc_path;
> + }
> +
> + SVN_INT_ERR(svn_wc_check_wc(wc_check_path, &wc_format, pool));
> if (! wc_format)
> {
> - svn_node_kind_t kind;
> - SVN_INT_ERR(svn_io_check_path(wc_path, &kind, pool));
> + SVN_INT_ERR(svn_io_check_path(wc_check_path, &kind, pool));
> if (kind == svn_node_dir)
> {
> SVN_INT_ERR(svn_cmdline_printf(pool, _("exported%s"),

The general rule for wc code is to avoid doing checks before an
operation and simply to do the operation and handle any error. In
this case svn_wc_revision_status uses svn_wc_adm_open_anchor so it
should handle versioned files. Can you avoid all the
svn_io_check_path and svn_wc_check_wc calls and simply call
svn_wc_revision_status, perhaps checking the error return if
necessary?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org