[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Was [PROPOSAL] Takeover Take 2

From: Paul Burba <paulb_at_softlanding.com>
Date: 2006-08-03 13:48:22 CEST

Julian Foad <julianfoad@btopenworld.com> wrote on 08/01/2006 05:59:27 PM:

> Paul Burba wrote:
> > Discussion of this patch fell by the wayside when I went on vacation.
> > believe this is ready to commit, but I wanted to check if anyone has
> > outstanding concerns regarding it. I'm in no major rush, but I'd like
> > get it into trunk.
> Hi Paul. I think it's time you checked in this patch. It's had
> ample time for
> review even though I still haven't got around to going through it as
> thouroughly as I would like to in an ideal world. But it's not
likeyou're a
> drive-by contributor: you're around to improve it later if people find
> that need your input. So just go for it. Enough people agree the
> functionality is good, and any deficiencies that remain by now must be

Yes, I'm too cautious at times, better than too reckless :-) Committed
> Some trivia I noticed:
> * main.c: Help text for "update" ends with a colon.
> * checkout_tests.py: whole content repeated in the patch file: take
> when applying the patch in case the unversioned file already exists,and
> you've "svn add"ed the file before committing.
> * checkout_tests.py: "'-m', 'Log message for new import'" is
> silly (I'd just
> write 'Import' or '').
> * checkout_tests.py: "Julian's scenario" -> proper brief description
> (something like "Ensure that an import followed by a checkout in place
> perfectly")
> * Some spaces at end of lines (now we're talking Julian-level trivia)

Fixed all.

> > Julian - I know you wanted to see a new option used rather than
> > but looking back in the takeover threads I don't see a firm consensus
> > this. If a new option is eventually what we decide on, I'll galdly
> > it later.
> I'm fine with putting it in as "--force" for now. I'd rather like it if
> could be renamed before it gets released, but that's for a separate
> discussion.

Ok, leaving this for a future debate.

Thanks for all your help,

Paul B.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 3 13:48:50 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.