[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Add help text for extensions in svn 1.4

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-07-31 23:10:34 CEST

> -----Original Message-----
> From: Karl Fogel [mailto:kfogel@google.com]
 
> I'm a bit confused by the new help text, and by the semantics
> of -x in general...
>
> When passing options through to an external diff-cmd, we
> shouldn't be interpreting the options at all -- they are
> opaque strings that we pass along to some external program
> we're firing up, end of story. So for that circumstance, the
> help text can't claim to know any of the meanings of the sub-options.

Yeah that's right. Current text doesn't show that clearly.

> When giving the user a way to change the behavior of our
> *internal* diff-cmd implementation, well, -x seems like an
> odd way to do that, but if we *are* going to use -x to do
> that, then the help text should make it clear that we're only
> talking about our internal diff implementation, Your Mileage
> May Vary, etc :-).

Well that seems to be the current choice for 1.4, so if you want to put this
up for further discussion, then better be quick :)

Attached patch has a slightly altered first sentence. Can you check if this
is correct? (my English isn't good enough to cram that much information in
such a small space).

> Independently of the above, I'd recommend using parens
> instead of square brackets, since the square brackets imply
> an optional param, not an alternate name for an option.

Hm, while I can agree with you here, why are the top-level options all
specified as '-c [--change]', -x [--extensions] arg' etc.? I don't see the
difference.

thanks for the review,

Lieven.

[[[
Add the help text for the new extensions added in 1.4:
'-b (--ignore-space-change)', '-w (--ignore-all-space)' and
'--ignore-eol-style'.

* subversion/svn/main.c
  (svn_cl__options): add description of the extensions.
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Jul 31 23:11:58 2006

This is an archived mail posted to the Subversion Dev mailing list.