[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix an l10n encoding error for a message displayed when a svn subcommand takes an inappropriate option taking an argument.

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-07-29 16:25:04 CEST

Kobayashi Noritada wrote:
>>>>The patch looks fine and safe, so +1 to commit it with my approval,
>>
>>I have now committed it in r20883. Thanks for the patch.
>
> Thank you for reviewing and committing my patch. I noticed that it was
> uninteresting for those who use only ASCII characters in their daily lives...

Hackers like to make all parts of the software work correctly even if we don't
use some parts of it.

> And, sorry for my late answer. I was a little bit busy for a few days...

No, no, it was me who was slow. (I would have committed at when I first
replied, except my working copy was broken at the time.)

>>I would tweak the log message a bit, as the change applies to the subcommand
>>name as well as to the strings generated by svn_utf_cstring_to_utf8.
>
> ...and thinking about the log message. Was it okay?

Yes, pretty good, thanks. I only made a small change.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 29 16:24:32 2006

This is an archived mail posted to the Subversion Dev mailing list.