Re: [PATCH] Fix an l10n encoding error for a message displayed when a svn subcommand takes an inappropriate option taking an argument.

Kobayashi Noritada wrote:
> [[[
> Fix an l10n encoding error for a message displayed when a svn subcommand
> takes an inappropriate option taking an argument.

Thanks, and sorry that it took so long to get a response.

The patch looks fine and safe, so +1 to commit it with my approval, though I
have only examined it and not actually tested it myself.

> This bug occurs only when using svn with a locale for which translation
> for a message " arg" contains non-ASCII characters. svnadmin, svnlook,
> and svnsync are not affected.
>
>
> * subversion/svn/main.c
> (main): Don't apply svn_utf_cstring_to_utf8 to UTF-8 strings generated
> by svn_opt_format_option, partly reverting r9795.
> ]]]

I would tweak the log message a bit, as the change applies to the subcommand
name as well as to the strings generated by svn_utf_cstring_to_utf8.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 26 01:14:08 2006