[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20617 - branches/1.4.x

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-07-25 01:31:15 CEST

Justin Erenkrantz wrote:
> On 7/23/06, Julian Foad <julianfoad@btopenworld.com> wrote:
>> >>Author: jerenkrantz
>> >>Date: Wed Jul 12 23:21:43 2006
>> >>New Revision: 20617
>> [...]
>> >>Log:
>> >>...I would have added the sleep to svn_client_merge2, but this is
>> fine too...
>> Please change that to a better log message.
> Huh? It's a vote, dude. I'm not going to waste my time coming up
> with an entire commit log message that just adds a vote to STATUS...

That commit log says *nothing* about the change. To anyone viewing log
messages without changed path information, it's a total "huh!?" moment.

Convention, as expressed in the majority of previous commits, suggests
that ideally log messages tweaking STATUS should begin "* STATUS: ", or
if not, at least mention the word 'vote'.

If you don't want to "waste your time", you can always fall back on the
boring but at least minimally informative: "* STATUS: Vote.".


Received on Tue Jul 25 01:32:05 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.