[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove excess elements from Atom 1.0 feeds

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2006-07-22 05:10:29 CEST

> Two problems here:
>
> 1) It would be a lot safer to base the insertion point on the first
> <entry>, not the position of <author>. <author> doesn't carry any useful
> information in the feeds we generate, and in fact I'm considering
> removing it.
>
> 2) Do not use parentheses around an if condition. It's very abnormal
> Python style.

Please find attached the patch for these two problems. IMO, even though
<author> doesn't carry any useful information in the feeds, the feed
readers *may* expect this tag to validate the feed file. So, i prefer to
retain it.

[[
Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>

* contrib/hook-scripts/svn2feed.py
  (Svn2Atom.add_revision_item): Locate the first "entry" element and
  insert the new element before that element. If the "entry" element
  does not exist, then append the new element to the end of feed file.

  Do not use parantheses around the "if" condition.
]]

-- 
Regards,
Bhuvaneswaran

Received on Sat Jul 22 05:11:41 2006

This is an archived mail posted to the Subversion Dev mailing list.