[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20740 - trunk/contrib/hook-scripts

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-07-20 21:25:47 CEST

C. Michael Pilato wrote:
> Bhuvaneswaran Arumugam wrote:
>>>> Some gentle preparatory changes toward merging Atom support into svn2rss.py.
>>>>
>>> I thought we'd originally discussed not doing this, because they didn't
>>> seem to share that much that was important? (and generating Atom feeds
>>> via something called svn2rss is a little strange, though we could rename
>>> it as well, I guess).
>>
>> Yes! As per [1], we have decided to have it separate.
>>
>> [1] http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=116597
>>
>> We discussed not doing this, because it would complicate things. We may
>> end up using PyRSS2Gen and atom specific library (xml.dom) in the same
>> script. In addition, we should tweak svn2rss.py (yeah, including the
>> script name) to match it to work for Atom feeds.
>>
>> So, i prefer to have them as separate scripts.
>
> I still say this is bogus, but I'll try to make sure this is the last time I
> say it. If we had a single script that did its option parsing first, and
> then tried to import only the modules it needs based on the feed type
> chosen, and then went about its business, I don't see the problem. Folks
> using RSS would still only have to have the PyRSS2Gen module. Folks using
> Atom would only have to have the Atom generation module. And we'd save
> ourselves a bundle of *completely* overlapping code.
>
> I'll volunteer to merge the two myself, unless it will break some hearts.

No need, I already have just as described above in my WC. I'll be
committing as soon as I've tested it a bit.

Max.

Received on Thu Jul 20 21:26:33 2006

This is an archived mail posted to the Subversion Dev mailing list.