[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: segfault in ruby bindings

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-07-19 17:35:21 CEST

Hi,

In <CEAB627200FA5C499F8CCB66C26905F30F0C01@wiems02014.ceu.corp.heidelberg.com>
  "segfault in ruby bindings" on Tue, 18 Jul 2006 11:39:33 +0200,
  "Husterer, Thomas RD-CP1" <Thomas.Husterer@heidelberg.com> wrote:

> For this reson I use the following code fragment:
>
> context.set_log_msg_func { |items|
> ret=@commitDialog.execute(items.join("\n"))
> if ret == 0
> raise Svn::Error::CANCELLED
> end
> [true, @commitDialog.text ]
> }
>
> I use 'set_log_msg_func' to hook-in a callback which starts the user dialog.
> Inside the dialog the user can edit the commit message, press ok or cancel.

> In case of 'cancel' there is no way to abort the calling function with a return
> value.
> The only way to manage this condition is to raise an exception.
>
> I use the exception 'Svn::Error::CANCELLED'.

> As a fast fix I use the following patch:
...
> Is this the right solution for this problem?

Yes. I fixed this problem in trunk (r20741).

> How comes this fix (or a better one) into the repository (trunk and 1.3.x)?

I nominated the fix (r20741) to the 1.3.x and 1.4.x
branches. So, this problem may be fixed in next 1.3.x and/or
1.4.x release.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 19 17:36:07 2006

This is an archived mail posted to the Subversion Dev mailing list.