[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Follow up for r18146.

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-07-18 21:06:44 CEST

On Tue, 18 Jul 2006, Garrett Rooney wrote:

> On 7/18/06, Madan U Sreenivasan <madan@collab.net> wrote:
> >Hi,
> >
> > I found a minor bug while looking at r18146. Pl. find patch attached to
> >fix this.
> >
> >[[[
> >Follow-up for r18146.
> >
> >* subversion/libsvn_repos/hooks.c:
                                    ^
                      Drop that character.

> > (run_hook_cmd): Actually capture the return value of
> > apr_file_inherit_unset() before testing for error.
> >]]]
>
> Looks fine to me, +1 to commit.

+1 to commit -- list rooneg and I in the "Approved by" field of your
log message. Please also propose this for backport to 1.4.x and list
me as a +1.

This is edge case-y enough that it should not be considered a blocker
for the 1.4.0 release.

- Dan

  • application/pgp-signature attachment: stored
Received on Tue Jul 18 21:07:41 2006

This is an archived mail posted to the Subversion Dev mailing list.