[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Follow up for r18146.

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-07-18 14:31:26 CEST

Hi,

   I found a minor bug while looking at r18146. Pl. find patch attached to
fix this.

[[[
Follow-up for r18146.

* subversion/libsvn_repos/hooks.c:
   (run_hook_cmd): Actually capture the return value of
    apr_file_inherit_unset() before testing for error.
]]]

Regards,
Madan.

Index: subversion/libsvn_repos/hooks.c
===================================================================
--- subversion/libsvn_repos/hooks.c (revision 20716)
+++ subversion/libsvn_repos/hooks.c (working copy)
@@ -83,7 +83,7 @@
       (apr_err, _("Can't make pipe read handle non-inherited for hook '%s'"),
        cmd);
 
- apr_file_inherit_unset(write_errhandle);
+ apr_err = apr_file_inherit_unset(write_errhandle);
   if (apr_err)
     return svn_error_wrap_apr
       (apr_err, _("Can't make pipe write handle non-inherited for hook '%s'"),

Follow-up for r18146.

* subversion/libsvn_repos/hooks.c:
  (run_hook_cmd): Actually capture the return value of
   apr_file_inherit_unset() before testing for error.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 18 14:01:19 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.