[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 1954

From: Philipp Marek <philipp_at_marek.priv.at>
Date: 2006-07-18 10:44:09 CEST

On Sunday 16 July 2006 11:21 Philipp Marek wrote:
> But the question would remain! It's not possible to allow *every* character
> in filenames, else eg. the dump format may be damaged (by \n in filenames).
> Similar a \r may cause problems on win32, and so on ....
To reiterate: It *is not possible* to allow all characters, so there has to be
some encoding/decoding.

> Is there a list of invalid characters *for the repository*, and/or do we
> simply define it as the current allowed list?
>
> I'd vote for not changing the behaviour (always a good bet :-), and simply
> defining an extension, eg. my idea 2 (encoding like "tab\\x09name", flag
> svn:filename-encoded).
>
> Is there any other/better kind to handle that?
If there are no other ideas/wishes, I'll implement that for fsvs.

Or would a patch for subversion/libsvn_subr/path.c be accepted, about this:
        char *svn_path_encode(const char *path, apr_pool_t *pool);
        char *svn_path_decode(const char *path, apr_pool_t *pool);
And I'd add something in subversion/include/svn_props.h, like
        #define SVN_PROP_FN_ENCODED SVN_PROP_PREFIX "filename-encoded"
        #define SVN_PROP_FN_ENCODED_VALUE "*"

How about that, so that all subversion clients would use the same
function/property?

Regards,

Phil

-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 18 10:44:44 2006

This is an archived mail posted to the Subversion Dev mailing list.