Re: svn commit: r20677 - trunk/subversion/bindings/swig

Hi,

2006/7/18, Max Bowsher <maxb1@ukf.net>:

> > The advantage for me is that this conversion is natural for
> > me. That is, converting a string that represents date in C
> > to Ruby's Time is natural C <-> Ruby type conversion.
>
> Agreed, but that was happening before r19545 anyway.
>
> > And I think such type conversion is SWIG layer work.
>
> This is the bit I'm asking about - why?
>
> If I understand correctly, the change does have an efficiency benefit -
> it avoids round-tripping a string from C -> Ruby -> C, but it does also
> mean that the SWIG layer is no longer a direct wrapper of the C API

I didn't think the efficiency benefit. I hoped that I get an
meintainabillity benefit. I think "string that represents date
in C to Ruby's Time" conversion is primitive conversion such as
int in C to Ruby's Integer, char * in C to Ruby's String and so
on. So, I think the conversion is "a direct wrapper of C API".
And it is natural that I moved the conversion to SWIG layer.

I hope my explain answers your question, Max.

Regards,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org