[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Unnecessary crippling of libsvn_fs_base. (Please stop it.)

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-07-14 18:25:24 CEST

I just noticed (as part of a conversation with Philipp Marek re: Issue 1954)
that in r12632, Karl added code to svn_fs_make_file(), _make_dir(), and
_copy() to call svn_path_check_valid() before creating new paths in the

Um. Why?

We have a repository layer for adding such superficial sanity checks.
There's nothing that I can think of that would cause filenames with control
characters to be a problem in libsvn_fs, unless the FSFS backend can't hack
it. Is that the case? If so, should we not have a) put the protection in
the repos layer, and b) also put it in the FSFS backend only? Why is the
BDB backend unnecessarily crippled like so?

C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Fri Jul 14 18:26:30 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.