[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20648 - in trunk/subversion: include libsvn_subr

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-07-14 16:54:46 CEST

dlr@tigris.org wrote:
> Author: dlr
> Date: Thu Jul 13 15:12:08 2006
> New Revision: 20648
> Modified:
> trunk/subversion/include/svn_config.h
> trunk/subversion/libsvn_subr/config_file.c
> Log:
> Fix broken API contract and numerous error leaks in
> svn_config_ensure(). The broken API contract resulted an error like
> the following when $HOME isn't accessible:
> svn: Can't check path '/home/thiru/.subversion': Permission denied

How is that a broken API contract? The contact mentions exactly two cases
in which errors should *not* be returned:

  - something exists but is the wrong kind
  - you fail while trying to create something

The "permission denied" case you site fits neither of those. So, where's
the problem? (I mean, besides those error leaks, which really *are* no-nos.)

C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Fri Jul 14 16:55:19 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.