Max Bowsher wrote:
> Max Bowsher wrote:
>> I just went to review r20600 for backport, and found serious terminology
>> confusion - namely, the change doesn't actually have anything to do with
>> what the log message describes.
>>
>> mailer.py has two separate concepts by which option values are processed:
>>
>> * 'maps': Defined in the [maps] section, and operate as lookup tables.
>> * 'parameters': Defined by predefinition and regexp matches, and
>> operate as string substitutions.
>>
>> The code change in r20600 actually enables parameter substitution for
>> several additional parameters - which is a good change.
>>
>> However, the log message repeatedly refers to 'maps' and 'mappings',
>> even quoting a comment from mailer.conf.example referring to mappings as
>> justification for the change.
>>
>>
>> I like the change, and am +1 on backporting the code to 1.4.x, but the
>> log message and STATUS metadata are highly misleading, and should be
>> fixed first.
>
> On the other hand, with a RC about to happen, I'll do STATUS and the
> merge, but the log message still needs fixing.
>
> Max.
>
I fixed the log message for r20600.
Regards,
Blair
--
Blair Zajac, Ph.D.
<blair@orcaware.com>
Subversion training, consulting and support
http://www.orcaware.com/svn/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 13 19:24:23 2006