[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20562 - trunk/subversion/include

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-07-13 00:45:09 CEST

Garrett Rooney wrote:
> On 7/11/06, maxb@tigris.org <maxb@tigris.org> wrote:
>> Author: maxb
>> Date: Tue Jul 11 10:01:44 2006
>> New Revision: 20562
>>
>> Modified:
>> trunk/subversion/include/svn_cmdline.h
>> trunk/subversion/include/svn_io.h
>>
>> Log:
>> API: Use named, not anonymous, structs and enums in new-in-1.4 cases, for
>> consistency with the majority of existing cases.
>>
>> * subversion/include/svn_io.h (svn_io_file_del_t)
>> * subversion/include/svn_cmdline.h (svn_cmdline_prompt_baton_t)
>
> Note that I actually prefer the other way, mainly because that way
> struct foo_t doesn't show up separately in doxygen output... It's
> also kind of silly to define struct foo_t when you always use it as
> foo_t.

Personally, I like the named form because it seems far more consistent
with other C language constructs to have the name of the thing you are
declaring at the beginning, rather than the end. Very significant in
the case of some of our structs, which extremely long definitions that
can stretch over multiple screens (e.g. svn_wc_entry_t - 141 lines).

Max.

Received on Thu Jul 13 00:45:43 2006

This is an archived mail posted to the Subversion Dev mailing list.