[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Really Fast 1.4.x API Review

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-07-10 23:48:10 CEST

I just did a probably-way-too-fast review of the new APIs in 1.4.x.

Other than the ones we're already trying to change, the only things I
found that were odd are the following:

- svn_client_list has the client ctx in the wrong place, should be the
second to last argument

- svn_wc_transmit_text_deltas2 has return value parameters at the end,
and it's using a char ** arg for a digest return, when usually we use
specifically sized char arrays for that.

The first seems like a no-brainer to me, easy to fix, low risk. The
second also seems pretty trivial, but I'm not as familiar with that
code, so I don't know if there's a reason for doing the digest arg
that way.

Thoughts?

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 10 23:48:35 2006

This is an archived mail posted to the Subversion Dev mailing list.