[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Need Ruby expertise to fix SvnClientTest::test_cleanup

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-07-06 15:37:15 CEST

Hi,

In <44AA8AE3.4020705@ukf.net>
  "Need Ruby expertise to fix SvnClientTest::test_cleanup" on Tue, 04 Jul 2006 16:36:03 +0100,
  Max Bowsher <maxb1@ukf.net> wrote:

> Recently, I tweaked the bindings so that the APR status and error codes
> were wrapped. As a side effect, that allowed the
> SVN_ERR_*_CATEGORY_START macros to be wrapped by SWIG.
>
> As a side effect of *that*, the Ruby bindings now have a bug:
>
> When a svn_error_t whose constant happens to be the first in its
> category (i.e., its apr_err equals one of the CATEGORY_START constants),
> Ruby thinks it has a FOO_CATEGORY_START error, not whatever the real
> error is.
>
> This is causing SvnClientTest::test_cleanup to fail.
>
> Someone needs to fix the "Ext::Core.constants.each do |const_name|" loop
> in svn/error.rb to ignore constants ending with _CATEGORY_START. Since I
> do not know any Ruby, that someone cannot be me.

I fixed this in r20447.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 6 15:41:10 2006

This is an archived mail posted to the Subversion Dev mailing list.