[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix references to svn_stream_t in Python bindings

From: David James <djames_at_collab.net>
Date: 2006-07-06 05:11:06 CEST

On 7/5/06, Jelmer Vernooij <jelmer@samba.org> wrote:
> [[[
> Allow Python code to drop its reference to a wrapped stream object.
> * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
> (close_handler_pyio): Add stream close handler.
> (svn_swig_py_make_stream): Increase stream reference count, set close
> handler.
> ]]]

+1. This is definitely a nice improvement. Could you commit a test
case with this? From a Python test, grab a weakref to the stream, and
check whether the stream is properly destroyed when the reference
count runs out.



David James -- http://www.cs.toronto.edu/~james
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 6 05:11:45 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.