[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: changelist feature in trunk, for toying with

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2006-07-04 03:52:44 CEST

On 7/3/06, David Glasser <glasser@mit.edu> wrote:
> Ben Collins-Sussman <sussman <at> red-bean.com> writes:
>
> > I wanted to point out that I've merged my changelist-feature branch to
> > trunk, so that you can play around with it now.
>
> I think this is a great feature and one I would use. At the risk of
> bikeshedding, I have to say that as a user, I think I would find the name
> "changelist" confusing.
>
> Specifically, the changelist (in the currently proposed/implemented design) is
> fundamentally *not* a list of changes: it's a list of files. The name "change
> list" implies to me that it applies at the level of individual hunk changes, not
> at the file-level granularity.

That would be a 'patch', right? A collection of hunk changes? :-)

> In addition, my intuitive guess as to what "svn
> changelist foo bar.c baz.h" would do would be to record *the current changes* in
> bar.c and baz.h into "foo", not just their names. In addition, "changelist"
> sounds very close to the concept of "changeset" from other SCMs which Subversion
> basically rolls into "revision".
>
> Obviously reading the documentation would set me straight here; however, I think
> that using a name that doesn't actually describe what the feature actually is is
> confusing. I think using a name like "file set" or something would be much more
> descriptive than "changelist".

It's not just a list of files, it's a list of paths. Paths can be
files or dirs.

I think the reason we've latched onto the term 'changelist' here is
because we're picking up the word from perforce. In fact, we're flat
out copying a lot of this idea from perforce, so we're trying to keep
momentum with the huge number of perforce users out there.

Take a look at the designdoc in notes/. Does it make things clearer?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 4 03:53:15 2006

This is an archived mail posted to the Subversion Dev mailing list.