[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] removing unexercised code from merge-tracking/subversion/libsvn_subr/mergeinfo.c

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2006-07-03 21:47:16 CEST

Kamesh Jayachandran wrote:
> Hi All,
> Find the attached patch.
>
> With regards
> Kamesh Jayachandran
>
> [[[
> Patch by: Kamesh Jayachandran <kamesh@collab.net>
>
> Removing unexcercised code.
>
> * subversion/libsvn_subr/mergeinfo.c
> (svn_rangelist_remove):
> 'if (elt1->start == elt2->start && elt1->end == elt2->end)' is taken
> care by range_contains and will never be exercised in the
> range_intersect block.
> ]]]
>
>

This is fine.

Could you change the range_contains case to do something like:

 if (range_contains(elt2, elt1))
        {
          i++;
          if (elt1->start == elt2->start && elt1->end == elt2->end)
            j++;
        }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 3 21:47:45 2006

This is an archived mail posted to the Subversion Dev mailing list.